Repository navigation
feat(pricing): add GET /price/:asset/fiat for local currency conversion and naira valuation (#290) - #529
Merged
Miracle656 merged 1 commit intoOct 22, 2026
Conversation
…on and naira valuation (Divinity-Labs#290)
sparkysolutions10-pixel
force-pushed
the
feat/fiat-pricing-naira-290
branch
from
October 19, 2026 20:23
449f6d8 to
373f389
Compare
Miracle656
added a commit
that referenced
this pull request
Oct 22, 2026
tsc --noEmit clean vitest 99 files, 1140 passing (up from 97 / 1135) dropped-tests none #280 close the vulnerabilities that are actually reachable #426 keep watched pairs as metric labels, bounded #529 GET /price/:asset/fiat for local currency #530 standard 429 response contract with retryAfter #530 pairs well with what landed earlier: #307 standardised empty-vs-missing status codes, and this does the same for rate limiting. An API that answers 429 without telling a client when to come back forces every consumer to invent its own backoff, and they will not agree. #461 (generate TypeScript and Python route snippets from the OpenAPI spec) was dropped. It fails three of its own tests even after running `npm run snippets:gen`: × render deterministically × committed files match the generator × contain no placeholder hosts or addresses The regeneration produced no files at all, so the generator is not doing what the test expects of it. The third case is the one I care about most -- a snippet carrying a placeholder address is exactly how an invented contract id reaches a contributor, which has already cost us a sweep. Worth getting right rather than merging around. Claude-Session: https://claude.ai/code/session_01USgemLt4Rnz4SGB1Srf3GB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #290
Summary of Changes
GET /price/:asset/fiatendpoint enabling valuation of Stellar assets in real-world fiat currencies.NGN) as well asUSD,EUR,GBP,KES,ZAR,CAD, andBRL.asset -> USD -> target_fiat) with fallback safety and timestamp tracking.openapi.yamland verified with automated unit tests insrc/__tests__/fiat.test.ts.